More extensive disentangling of Policy Traits (Replaces #3564) #3829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 3, 2021 10:16
Right now, the size of the code for AnalyzePolicy scales quadratically with the number of traits we analyze. With this change, the scaling is linear and adding a new trait doesn't have to touch any other code.
The details of the runtime storage that may be associated with a policy trait is now implemented only as part of the trait-specific specializations. Traits are now fully disjoint with the exception of defaults in AnalyzePolicy<void> and PolicyTraitsWithDefaults
dhollman
force-pushed
the
analyze-policy-refactor-2
branch
from
e900362
to
49c4925
Compare
- made implementation of `require` and `prefer` much easier
- introduced the notion of a TraitSpecification, which helper
templates use to make these things easier
- moved specification of defaults to a place more directly
associated with the trait itself.
dhollman
force-pushed
the
analyze-policy-refactor-2
branch
6 times, most recently
from
d21c7b4
to
435e71b
Compare
dhollman
force-pushed
the
analyze-policy-refactor-2
branch
from
435e71b
to
200dc06
Compare
dalg24
reviewed
Mar 5, 2021
added 2 commits
March 8, 2021 10:54
dhollman
force-pushed
the
analyze-policy-refactor-2
branch
from
b76e43a
to
eac7b4a
Compare
dhollman
force-pushed
the
analyze-policy-refactor-2
branch
from
eac7b4a
to
c0753aa
Compare
dhollman
force-pushed
the
analyze-policy-refactor-2
branch
from
6f7c6b8
to
4460416
Compare
added 2 commits
March 8, 2021 12:42
Reproducer: https://godbolt.org/z/r7GT6c Toy example of workaround strategy: https://godbolt.org/z/YWjx83 Basically, we need to linearize the series of base classes to get MSVC to do empty base optimization. It makes things a little uglier, but I've tried to isolate as much of the workaround as possible
dhollman
force-pushed
the
analyze-policy-refactor-2
branch
from
4460416
to
0cf44b9
Compare
dhollman
changed the title
dhollman
changed the title
|
Retest this please. |
DavidPoliakoff
previously requested changes
Mar 10, 2021
|
Frustratingly, the results are compiler-dependent. Clang, this performs just fine with. Intel 19, it does pretty poorly, unfortunately. Daisy and I are discussing |
|
@DavidPoliakoff's results appear to be in error, and we've talked about them. For Intel 19.0.5 with OpenMP and Serial enabled and Both #3829 and #3832 reduce the size of the compiled output. The build times for all three are within the noise; about 2:10 seconds for |
|
I'd cosign that, actually. I could see a methodology error that leads to different build times, but not binary sizes. I frankly don't have the time to reproduce, so go with Daisy's time, write it up to methodology errors, my bad |
dalg24
approved these changes
Mar 12, 2021
Comment on lines
+99
to
+100
| template <class Policy, class ScheduleType> | ||
| constexpr auto require(Policy const& p, Kokkos::Schedule<ScheduleType>) { |
There was a problem hiding this comment.
Note that this is a new functionality. (I do not have any objection just wanted to highlight it.)
dhollman
force-pushed
the
analyze-policy-refactor-2
branch
from
d8d2c96
to
0cf44b9
Compare
|
Retest this please. |
|
Retest this please. |
crtrott
added a commit
that referenced
this pull request
Apr 12, 2021
(Builds on #3829) More disentangling of AnalyzePolicy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
requireandprefermuch easierTraitSpecification, which helper templates use to make these things easierrequireandpreferoverloads to be with the traits they interact with.