Add an option to disable header self containment tests #3834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dalg24
commented
Mar 9, 2021
Comment on lines
-4
to
-8
| # Globbing all the header filenames to test for self-containment and presence of header guards | ||
| KOKKOS_OPTION(DEFAULT_DEVICE_MEMORY_SPACE "" STRING "Override default device memory space") | ||
| KOKKOS_OPTION(DEFAULT_HOST_MEMORY_SPACE "" STRING "Override default host memory space") | ||
| KOKKOS_OPTION(DEFAULT_DEVICE_EXECUTION_SPACE "" STRING "Override default device execution space") | ||
| KOKKOS_OPTION(DEFAULT_HOST_PARALLEL_EXECUTION_SPACE "" STRING "Override default host parallel execution space") |
There was a problem hiding this comment.
Note that I removed these lines
masterleinad
reviewed
Mar 9, 2021
Co-authored-by: Daniel Arndt <arndtd@ornl.gov>
dalg24
force-pushed
the
disable_header_self_containment_tests
branch
from
ecaa9cf
to
788a947
Compare
DavidPoliakoff
approved these changes
Mar 10, 2021
crtrott
approved these changes
Mar 10, 2021
masterleinad
added a commit
to masterleinad/kokkos
that referenced
this pull request
Mar 11, 2021
* Remove misplaced options declarations * Add option to disable header self containment tests * Apply suggestions from code review (CMake indentation) Co-authored-by: Daniel Arndt <arndtd@ornl.gov> * Move HEADER_SELF_CONTAINMENT_TESTS option declaration Co-authored-by: Daniel Arndt <arndtd@ornl.gov>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default is
ONwhich means the current behavior is unchanged. You may configure with-DKokkos_ENABLE_ HEADER_SELF_CONTAINMENT_TESTS=OFFto opt in.Motivation for that is in my opinion the header self-containment unit tests are not so helpful while developing. I routinely comment out the add_subdirectory(headers_self_contained) in my local build and I have many times committed that change by accident.