Restrict MDRange Policy tests for Intel GPUs #3853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should we have a fixme sycl? I mean in general we probably can just grep for "SYCL" in all our unit test files instead. |
I don't know if this will ever be "fixed" I would think this is permanent until we don't care for GPUs with a restriction to 256 threads/workgroup anymore. |
crtrott
approved these changes
Mar 17, 2021
|
We probably should add something like "Max Tile Size" or change the implementation to allow tile size > block/group size. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The maximum workgroup size for some GPUs is 256 so it's helpful to decrease the tile size product to also allowing testing with them when using SYCL.