Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement option to disable deprecation warnings #3855

Merged
merged 3 commits into from
Apr 27, 2021
Merged

Implement option to disable deprecation warnings #3855

merged 3 commits into from
Apr 27, 2021

Conversation

masterleinad
Copy link
Contributor

The new option currently just disables deprecation warnings for code marked with KOKKOS_DEPRECATED. At the moment, the default is ON changing the current behavior. For all CI, the option is OFF, though.
We might actually hide code depending on this option later.

@crtrott
Copy link
Member

crtrott commented Mar 18, 2021

why rename it to _3? I mean we don't have a 2 and 1 and generally I think its ok to have an option which affects all "currently deprecated" stuff.

@masterleinad
Copy link
Contributor Author

why rename it to _3? I mean we don't have a 2 and 1 and generally I think its ok to have an option which affects all "currently deprecated" stuff.

That's the name we come up with in https://github.com/kokkos/internal-documents/blob/0fe07f0e040aaf845c889a5ada3a3a09e36e8e11/developer-notes/deprecation-policy.md. I thought we wanted something major release specific.

@masterleinad masterleinad added the Blocks Promotion Overview issue for release-blocking bugs label Mar 24, 2021
@masterleinad masterleinad added this to the Tentative 3.4 Release milestone Mar 24, 2021
@dalg24 dalg24 removed the Blocks Promotion Overview issue for release-blocking bugs label Mar 31, 2021
crtrott
crtrott requested changes Apr 27, 2021
View reviewed changes
Copy link
Member

@crtrott crtrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need tests with deprecated code on for sure. In particular since that is what the default setting is. So only do one or two configs with it off, and most of it with it on.

@masterleinad
Copy link
Contributor Author

We need tests with deprecated code on for sure. In particular since that is what the default setting is. So only do one or two configs with it off, and most of it with it on.

Done. Now, only the MacOS builds, one CUDA build, and one HIP build will emit warnings for deprecated code.

@crtrott crtrott merged commit 4b9a6c5 into kokkos:develop Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crtrott crtrott crtrott approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Tentative 3.5 Release
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@masterleinad @crtrott @dalg24