Improve readability of the callback invocation in profiling #3860

dalg24 · 2021-03-18T13:26:01Z

invoke_kokkos_callback -> invoke_kokkosp_callback
std::{true,false}_type -> MayRequireGlobalFence::{Yes,No}
let MayRequireGlobalFence::{Yes,No} be the 1st argument instead of passing it between the callback and its arguments
more consistency when qualifying names

Co-Authored-By: Nevin Liber <nliber@anl.gov>

DavidPoliakoff

Does what it says on the tin

core/src/impl/Kokkos_Profiling.cpp

…tches true Co-Authored-By: Nevin Liber <nliber@anl.gov>

dalg24 and others added 4 commits March 17, 2021 10:25

Rename invoke_kokkos_callback -> invoke_kokkosp_callback

2e4a4a2

Prefer MayRequireGlobalFence::{Yes,No} to std::{true,false}_type

846aa79

Co-Authored-By: Nevin Liber <nliber@anl.gov>

Vain attempt to regularize qualification of names in profiling

1b786da

Oops

0b166df

dalg24 requested a review from DavidPoliakoff March 18, 2021 13:26

Fix typos

3aeb5a7

DavidPoliakoff approved these changes Mar 18, 2021

View reviewed changes

dalg24 requested a review from nliber March 19, 2021 20:43

nliber requested changes Mar 19, 2021

View reviewed changes

core/src/impl/Kokkos_Profiling.cpp Outdated Show resolved Hide resolved

Switch order of enumerators in MayRequireGlobalFencing so that Yes ma…

2791e3f

…tches true Co-Authored-By: Nevin Liber <nliber@anl.gov>

nliber approved these changes Mar 22, 2021

View reviewed changes

dalg24 merged commit ef05e8c into kokkos:develop Mar 22, 2021

dalg24 deleted the cleanup_profiling branch March 22, 2021 15:40

Provide feedback