Fix bug {pow, log}(Kokkos::complex) #3866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Vinh Dang <vqdang@sandia.gov>
dalg24
force-pushed
the
bug_log_and_pow_complex
branch
from
289025a
to
7d8fdd6
Compare
| @@ -720,7 +720,7 @@ KOKKOS_INLINE_FUNCTION Kokkos::complex<RealType> pow(const complex<RealType>& x, | |||
| using std::pow; | |||
| using std::sin; | |||
| #endif | |||
| RealType phi = atan(x.imag() / x.real()); | |||
| RealType phi = atan2(x.imag(), x.real()); | |||
There was a problem hiding this comment.
Don't you also have to import sycl::atan2 instead of sycl::atan and std::atan2 instead of syd::atan?
There was a problem hiding this comment.
Fixed.
Note that we should really be using the math functions from Kokkos::Experimental::
Co-Authored-By: Vinh Dang <vqdang@sandia.gov>
dalg24
force-pushed
the
bug_log_and_pow_complex
branch
from
a78673e
to
80e162c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3865