Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compiling SYCL with OpenMP #3874

Merged
merged 2 commits into from
Mar 24, 2021
Merged

Fix compiling SYCL with OpenMP #3874

merged 2 commits into from
Mar 24, 2021

Conversation

masterleinad
Copy link
Contributor

@masterleinad masterleinad commented Mar 23, 2021 •
edited

Apparently, some of the compilers still also do a device pass even when only activating OpenMP. I checked that with this pull request I could run the tests with OpenMP alone and with OpenMP and SYCL. AFAICT, the SYCL CI doesn't support OpenMP as of now, though.

@masterleinad masterleinad changed the title [WIP] Fix compiling SYCL with OpenMP Fix compiling SYCL with OpenMP Mar 24, 2021
@masterleinad
Copy link
Contributor Author

@nliber Can you try if this also works for you?

@masterleinad masterleinad marked this pull request as ready for review March 24, 2021 02:34
@masterleinad
Copy link
Contributor Author

Retest this please.

@dalg24 dalg24 merged commit b3b0498 into kokkos:develop Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dalg24 dalg24 dalg24 approved these changes

@nliber nliber nliber approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@masterleinad @dalg24 @nliber