Fixup absolute value of floating points in Kokkos complex #3882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dalg24
commented
Mar 24, 2021
Comment on lines
802
to
808
| #ifdef KOKKOS_ACTIVE_EXECUTION_MEMORY_SPACE_SYCL | ||
| using sycl::abs; | ||
| using sycl::fabs; | ||
| using sycl::sqrt; | ||
| #else | ||
| using std::abs; | ||
| using std::fabs; | ||
| using std::sqrt; | ||
| #endif |
There was a problem hiding this comment.
Shouldn't this just be
using Kokkos::Experimental::fabs;
using Kokkos::Experimental::sqrt;
?
There was a problem hiding this comment.
Fixing in upcoming PR that will pull all the #ifdef KOKKOS_ACTIVE_EXECUTION_MEMORY_SPACE_SYCL
| return Kokkos::complex<RealType>(t, i < RealType() ? -t : t); | ||
| } else { | ||
| RealType t = sqrt(2 * (abs(x) + abs(r))); | ||
| RealType t = sqrt(2 * (abs(x) + fabs(r))); |
There was a problem hiding this comment.
Suggested change
| RealType t = sqrt(2 * (abs(x) + fabs(r))); | |
| RealType t = sqrt(2 * (fabs(x) + fabs(r))); |
?
There was a problem hiding this comment.
No. I did the same mistake before. x is a Kokkos::complex.
dalg24
force-pushed
the
kokkos_complex_prefer_fabs
branch
from
502865f
to
90fca96
Compare
|
No changes. Just rebased with autosquash |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As in #3880 motivated by removing SYCL specific preprocessor directives in
<Kokkos_Complex.hpp>In the process discovered that we are using
std::fabsin device functions which is not allowed with SYCL.