Reuse scratch memory in SYCL TeamPolicy #3889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masterleinad
commented
Mar 26, 2021
|
The whole implementation is pretty much taken from the |
dalg24
reviewed
Mar 26, 2021
nliber
approved these changes
Mar 26, 2021
masterleinad
force-pushed
the
sycl_reuse_memory_team
branch
from
11461d3
to
140418b
Compare
|
Plz rebase |
masterleinad
force-pushed
the
sycl_reuse_memory_team
branch
from
140418b
to
e22fd64
Compare
Done. |
dalg24
reviewed
Apr 7, 2021
| @@ -42,6 +42,7 @@ | |||
| //@HEADER | |||
| */ | |||
|
|
|||
| #include <Kokkos_Core.hpp> | |||
There was a problem hiding this comment.
Why are you including <Kokkos_Core.hpp>?
There was a problem hiding this comment.
This is for kokkos_malloc. I could try forward declaring in Kokkos_core_fwd.hpp instead.
There was a problem hiding this comment.
It just makes little sense to include everything and below include selected headers.
masterleinad
force-pushed
the
sycl_reuse_memory_team
branch
from
c1cfd5c
to
ea6479e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #3873, we can reuse the scratch memory allocated for
TeamPolicy.