Reuse memory in SYCL parallel_scan #3899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masterleinad
force-pushed
the
sycl_reuse_memory_parallel_scan
branch
from
7283ec1
to
2f7e870
Compare
|
Retest this please. |
nliber
requested changes
Apr 2, 2021
nliber
approved these changes
Apr 2, 2021
dalg24
reviewed
Apr 7, 2021
| // FIXME_SYCL consider only storing one value per block and recreate initial | ||
| // results in the end before doing the final pass | ||
| m_scratch_space = static_cast<pointer_type>( | ||
| instance.scratch_space(sizeof(value_type) * total_memory)); |
There was a problem hiding this comment.
Doesn't total_memory already take into account sizeof(value_type)?
There was a problem hiding this comment.
Oh, you're right.
There was a problem hiding this comment.
Comment on lines
+227
to
+238
| std::size_t total_memory = 0; | ||
| { | ||
| size_t wgroup_size = 32; | ||
| size_t n_nested_size = len; | ||
| size_t n_nested_wgroups; | ||
| do { | ||
| total_memory += sizeof(value_type) * n_nested_size; | ||
| n_nested_wgroups = (n_nested_size + wgroup_size - 1) / wgroup_size; | ||
| n_nested_size = n_nested_wgroups; | ||
| } while (n_nested_wgroups > 1); | ||
| total_memory += sizeof(value_type) * wgroup_size; | ||
| } |
There was a problem hiding this comment.
Comment on what is going on here.
There was a problem hiding this comment.
|
Retest this please. |
1 similar comment
|
Retest this please. |
crtrott
approved these changes
Apr 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on top of #3873. This should be the last occurrence of a raw call to
sycl::mallocoutside ofSYCLDeviceUSMSpace::allocate()orSYCLSharedUSMSpace::allocate()