#3785: Add execution space arguments for constructor overloads that might allocate a new underlying View #3904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
I neglected that these constructor overloads were used in EMPIRE |
|
Could I please get a review on this @dalg24 @DavidPoliakoff @masterleinad @crtrott ? |
|
OK to test |
PhilMiller
force-pushed
the
3785-scatterview-execspace
branch
3 times, most recently
from
364e97d
to
6871d8e
Compare
…that might allocate a new underlying View
PhilMiller
force-pushed
the
3785-scatterview-execspace
branch
from
6871d8e
to
c3f7247
Compare
dalg24
reviewed
Mar 30, 2021
|
Ok, I'll make that revision. It makes the calling code simpler too.
|
PhilMiller
force-pushed
the
3785-scatterview-execspace
branch
from
d2cfd26
to
f8918ec
Compare
PhilMiller
force-pushed
the
3785-scatterview-execspace
branch
from
f8918ec
to
39e217e
Compare
dalg24
reviewed
Mar 31, 2021
|
Will this make it into the 3.4 release? |
It's negotiable. I suppose it means you would like us to include this patch in the release? |
|
yes - if possible. Short term, we will be adding it an application's internal fork of trilinos/kokkos. But we don't want to be out of sync from the releases for too long. Too easy to introduce incompatibility issues. |
|
Ping - anything else needed from me before this gets reviewed and merged? |
dalg24
approved these changes
Apr 7, 2021
crtrott
approved these changes
Apr 7, 2021
seamill
pushed a commit
to seamill/Trilinos
that referenced
this pull request
Jul 28, 2021
…that might allocate a new underlying View Patched from the upstream kokkos/kokkos repository into EM-Plasma/Trilinos by request of @pbmille and @rppawlo. See kokkos/kokkos#3904.
seamill
pushed a commit
to seamill/Trilinos
that referenced
this pull request
Jul 28, 2021
Patching Kokkos#3904 into EM-Plasma/Trilinos ahead of the next Kokkos release. See kokkos/kokkos#3904. * kokkos-3785: Kokkos#3785: Add execution space arguments for constructor overloads that might allocate a new underlying View
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-on to #3786