[HIP] fix multithreaded access to get_next_driver #3908
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In HIP, we have a pool of Drivers that we use when launching a kernel. If two threads try to launch a kernel at the same time, they could both use the same Driver from the pool. This PR uses a lock to prevent this scenario. I have measured the impact of an uncontested lock using the code in #3670 and I did not see any penalty.