Use strcmp to compare names() #3909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wow, funny timing, I'll close mine |
DavidPoliakoff
approved these changes
Mar 31, 2021
dalg24
requested changes
Mar 31, 2021
There was a problem hiding this comment.
Use ASSERT_STREQ
https://google.github.io/googletest/primer.html#string-comparison
|
Doesn't this do the same? |
No. If the assertion was to fail, your solution prints something like expected TRUE got FALSE while mine prints the non matching strings. |
masterleinad
force-pushed
the
fix_intel_17_0_1
branch
from
0fd6eb8
to
7084cce
Compare
OK, changed (and tested). |
dalg24
approved these changes
Apr 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partly fixes #3906.