Provide forward declarations in Kokkos_ViewLayoutTiled.hpp for XL #3911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndellingwood
approved these changes
Apr 5, 2021
nliber
reviewed
Apr 7, 2021
| @@ -659,6 +659,91 @@ struct ViewOffset< | |||
| : 0) {} | |||
| }; | |||
|
|
|||
| // FIXME Remove the out-of-class definitions when we require C++17 | |||
| #define KOKKOS_ITERATE_VIEW_OFFSET_ENABLE \ | |||
| typename std::enable_if<((Dimension::rank <= 8) && (Dimension::rank >= 2) && \ | |||
There was a problem hiding this comment.
Minor: Now that C++14 is the base, can we use enable_if_t?
Minor: I would expect to see the two Dimension::rank checks reversed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partly fixes #3907. I checked compiling with XL myself.