Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider std::sort when view is accessible from host #3929

Merged
merged 1 commit into from
Apr 16, 2021
Merged

Consider std::sort when view is accessible from host #3929

merged 1 commit into from
Apr 16, 2021

Conversation

dalg24
Copy link
Member

@dalg24 dalg24 commented Apr 12, 2021

@dalg24 dalg24 requested a review from vqd8a April 12, 2021 15:34
vqd8a
vqd8a approved these changes Apr 12, 2021
View reviewed changes
Copy link
Contributor

@vqd8a vqd8a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dalg24 Thanks for fixing this.

masterleinad
masterleinad approved these changes Apr 12, 2021
View reviewed changes
Copy link
Contributor

@masterleinad masterleinad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Note that Kokkos::sort takes a second argument that allows forcing to avoid the std::sort path.

@crtrott crtrott merged commit a0d0cf3 into kokkos:develop Apr 16, 2021
@dalg24 dalg24 deleted the try_std_sort_if_accessible_from_host branch May 24, 2021 21:38
@jstrzebonski jstrzebonski mentioned this pull request Aug 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@masterleinad masterleinad masterleinad approved these changes

@vqd8a vqd8a vqd8a approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dalg24 @masterleinad @vqd8a @crtrott