Disable hypot long double test on power arches #3962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dalg24
approved these changes
Apr 23, 2021
| @@ -601,8 +601,10 @@ TEST(TEST_CATEGORY, mathematical_functions_power_functions) { | |||
| do_test_math_binary_function<TEST_EXECSPACE, kk_hypot>(2.f, 3.f); | |||
| do_test_math_binary_function<TEST_EXECSPACE, kk_hypot>(2., 3.); | |||
| #ifdef MATHEMATICAL_FUNCTIONS_HAVE_LONG_DOUBLE_OVERLOADS | |||
| #if !(defined(KOKKOS_ARCH_POWER8) || defined(KOKKOS_ARCH_POWER9)) | |||
There was a problem hiding this comment.
Suggested change
| #if !(defined(KOKKOS_ARCH_POWER8) || defined(KOKKOS_ARCH_POWER9)) | |
| #if !(defined(KOKKOS_ARCH_POWER8) || defined(KOKKOS_ARCH_POWER9)) // FIXME |
There was a problem hiding this comment.
Amended the PR with the change and applied clang-format
ndellingwood
force-pushed
the
disable-ldhypot-power
branch
from
e19860f
to
c967973
Compare
ajpowelsnl
assigned ajpowelsnl, jrmadsen and ndellingwood and unassigned ajpowelsnl, jrmadsen and ndellingwood
ndellingwood
added a commit
to ndellingwood/kokkos
that referenced
this pull request
Sep 22, 2022
Disable test on Power9 (and Power8) arches Similar treatment for kk3_hypot as kk_hypot in kokkos#3962
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.