Add missing specailization for OMPT to Kokkos Random #3967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Retest this please. |
masterleinad
previously requested changes
Apr 28, 2021
crtrott
force-pushed
the
omptarget-random_unique_index
branch
from
f152499
to
7394dd8
Compare
crtrott
force-pushed
the
omptarget-random_unique_index
branch
from
7394dd8
to
af18499
Compare
masterleinad
reviewed
May 6, 2021
dalg24
approved these changes
May 6, 2021
| // FIXME_OPENMPTARGET: Need this for OpenMPTarget because contra to the standard | ||
| // llvm requires the binary operator defined not just the += | ||
| KOKKOS_INLINE_FUNCTION | ||
| RandomProperties operator+(const RandomProperties& org, |
OpenMPTarget algorithms unit test CMake: less convoluted condition Co-authored-by: Daniel Arndt <arndtd@ornl.gov>
Co-authored-by: Daniel Arndt <arndtd@ornl.gov>
rgayatri23
approved these changes
May 6, 2021
algorithms/src/Kokkos_Random.hpp
Outdated
| using locks_view_type = View<int*, Kokkos::Experimental::OpenMPTarget>; | ||
| KOKKOS_FUNCTION | ||
| static int get_state_idx(const locks_view_type& locks) { | ||
| const int i = omp_get_team_num() * 1024 + omp_get_thread_num(); |
There was a problem hiding this comment.
why 1024 instead of 2048 ?
crtrott
added a commit
that referenced
this pull request
May 12, 2021
[3.4.1] Take over #3967: Add missing specailization for OMPT to Kokkos Random
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.