Retrieve original value from a point in a MultidimensionalSparseTuningProblem #3977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
You need to reformat the code. |
Rombur
approved these changes
Apr 28, 2021
|
@Rombur added tests. Unfortunately, even with clang-format from clang 8.0.0, clang-format -i on the failing files isn't changing anything for me (and it does pick up the .clang-format we want). I may just manually change what the patch says to do, but it's a bit obnoxious to have to fight this hard over " &" versus "& " |
|
I think there is a problem with the last commit. The commit message says that you added a test but the commit itself just removes a blank line. |
|
Also, there a lot of whitespace changes that are out-of-sope... Not sure what's going on. |
|
Again, if it passes CI, I don't worry further about formatting. It's just not the important thing to me |
|
I think the still you wanted to add is still missing. |
masterleinad
reviewed
May 4, 2021
masterleinad
reviewed
May 4, 2021
masterleinad
approved these changes
May 4, 2021
Co-authored-by: Daniel Arndt <arndtd@ornl.gov>
…Poliakoff/kokkos into feature/retrieve-points-from-tuner
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows a user to get a configuration from a MSTP given a point in its configuration space. This means that if a tool can produce code representing its heuristics, the generated code can be used in a library to configure itself without a tuner