Add file and line to error message #3985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dalg24
approved these changes
Apr 29, 2021
DavidPoliakoff
approved these changes
Apr 29, 2021
nliber
previously requested changes
Apr 30, 2021
core/src/impl/Kokkos_Error.hpp
Outdated
| @@ -47,6 +47,7 @@ | |||
|
|
|||
| #include <string> | |||
| #include <iosfwd> | |||
| #include <cstdio> | |||
There was a problem hiding this comment.
Good point, I have remove it.
| "Kokkos contract violation:\n " \ | ||
| " Expected precondition `" #__VA_ARGS__ "` evaluated false."); \ | ||
| } \ | ||
| #define KOKKOS_IMPL_STRINGIFY(x) #x |
There was a problem hiding this comment.
Is this the right header for KOKKOS_IMPL_STRINGIFY and KOKKOS_IMPL_TOSTRING?
(It might be, because this is the only place it is used, and we can always move it later if we need it again. I'm just asking.)
There was a problem hiding this comment.
I had the same dilemma when I wrote this. I've put that here since it's the only place it is used. If it's useful somewhere else later on we can always move it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add file and line to error message from
KOKKOS_EXPECTS,KOKKOS_ENSURES, andKOKKOS_ASSERT. This makes it a lot simpler to find where the error has been triggered from.