Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Trilinos only] Keep quoted compiler flags when passing to Trilinos #3987

Merged
merged 1 commit into from
May 6, 2021

Conversation

masterleinad
Copy link
Contributor

For SYCL we need compiler flags that contain quotes when using the AOT compiler (which is currently required on some platforms due to compiler issues with the AOT compiler). These quotes seem to get stripped when passing them to Trilinos. It seems that simply quoting all flags individually seems to work around the issue but I'm happy if someone has better suggestions.

@ndellingwood Can you please check if building Trilinos with this works?

@junghans
Copy link
Contributor

@masterleinad: The undefined reference to std::__failed_assertion()'foricpcinDebug` is unrelated, I saw this in my other PR as well.

@masterleinad
Copy link
Contributor Author

Yeah, this shouldn't have any impact on our CI.

@ndellingwood
Copy link
Contributor

@masterleinad sorry I missed the message for this in my inbox, I'll test Trilinos and get back to you

@crtrott
Copy link
Member

crtrott commented May 5, 2021

Waiting on @ndellingwood to test this. If its ok I approve.

Copy link
Contributor

@ndellingwood ndellingwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OpenMP and Cuda builds of Trilinos look good with this change included

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants