staticcsrgraph: use device type instead of execution space to construct views #3991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
…ct views Using the execution space to construct views internally can lead to issues when the staticcrsgraph itself is built using a non default memory space. This leads to build failures in Tpetra on AMD. Closes issue kokkos#3990. Applying clang-format
|
Looks good to me. Pretty much what I would have done in a few minutes. 🙂 |
lucbv
force-pushed
the
hiphostpinned_create_staticcsrgraph
branch
from
5540e56
to
05901a8
Compare
|
@masterleinad |
masterleinad
approved these changes
Apr 30, 2021
|
OK to test. |
|
OK to test |
|
@masterleinad there is a build failing but the error is not pointing at Kokkos code explicitly and I do not have access to that machine, is there a simple way to reproduce this? |
|
Don't worry about that failure. We recently updated the CI container images and it has been failing since. |
dalg24
approved these changes
May 1, 2021
dalg24
added a commit
that referenced
this pull request
May 5, 2021
[3.4.1] Take over #3991: staticcsrgraph: use device type instead of execution space to construct views
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the execution space to construct views internally can lead to issues when the staticcrsgraph itself is built using a non default memory space.
This leads to build failures in Tpetra on AMD.
Closes issue #3990.