Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: icpx is now part of intel container #4002

Merged
merged 1 commit into from
May 6, 2021
Merged

Conversation

junghans
Copy link
Contributor

@junghans junghans commented May 5, 2021

related to kokkos/ci-containers#17

We will need to merge this fix up into devel as well.

/cc @dalg24

Copy link
Member

@dalg24 dalg24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No do not target master. Change it to develop plz

@dalg24 dalg24 changed the base branch from master to develop May 5, 2021 20:03
@dalg24 dalg24 changed the base branch from develop to master May 5, 2021 20:03
@junghans
Copy link
Contributor Author

junghans commented May 5, 2021

Where should it go now?

@dalg24
Copy link
Member

dalg24 commented May 5, 2021

develop

@dalg24
Copy link
Member

dalg24 commented May 5, 2021

it needs a rebase

crtrott added a commit that referenced this pull request May 5, 2021
[3.4.1] Take over #4002: CI: icpx is not part of intel container
@junghans junghans changed the title CI: icpx is not part of intel container CI: icpx is now part of intel container May 6, 2021
@junghans junghans changed the base branch from master to develop May 6, 2021 02:03
@junghans
Copy link
Contributor Author

junghans commented May 6, 2021

it needs a rebase

Done.

We will need to update it in all other branches using intel-openapi as well, like in #4004.

@junghans junghans requested a review from dalg24 May 6, 2021 02:05
@junghans
Copy link
Contributor Author

junghans commented May 6, 2021

@dalg24 dalg24 merged commit 3efc176 into kokkos:develop May 6, 2021
@dalg24
Copy link
Member

dalg24 commented May 6, 2021

Once merged, we should remove https://github.com/orgs/kokkos/packages/container/ci-containers%2Ffedora/2368320?tag=intel-oneapi

Can you take of it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants