Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TestDetectionIdiom.cpp test inclusion for Trilinos/TriBITS #4010

Merged
merged 1 commit into from
May 7, 2021
Merged

Fix TestDetectionIdiom.cpp test inclusion for Trilinos/TriBITS #4010

merged 1 commit into from
May 7, 2021

Conversation

ndellingwood
Copy link
Contributor

The TestDetectionIdiom test inclusion caused configuration errors in Trilinos nightly builds:

CMake Error at kokkos/core/unit_test/CMakeLists.txt:68 (add_executable):
  Target "TestCompileOnly" links to target "Kokkos::kokkos" but the target
  was not found.  Perhaps a find_package() call is missing for an IMPORTED
  target, or an ALIAS target is missing?

Replacing test inclusion with KOKKOS_ADD_EXECUTABLE_AND_TEST resolved the issue for me in Trilinos and standalone Kokkos builds.

@ndellingwood ndellingwood requested a review from dalg24 May 6, 2021 18:53
dalg24
dalg24 reviewed May 6, 2021
View reviewed changes
core/unit_test/CMakeLists.txt
TestCompileOnly
SOURCES
TestDetectionIdiom.cpp
)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well I only meant to add an executable. Does KOKKOS_ADD_EXECUTABLE work?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I amended the PR with the change

@dalg24 dalg24 merged commit 2265de3 into kokkos:develop May 7, 2021
@ndellingwood ndellingwood deleted the fix-trilinos-config branch May 7, 2021 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dalg24 dalg24 dalg24 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ndellingwood @dalg24