Work around SYCL JIT compiler issues with static variables #4013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rombur
approved these changes
May 10, 2021
crtrott
reviewed
May 10, 2021
| @@ -109,7 +109,7 @@ class SYCLInternal { | |||
| assert(m_mem); | |||
| assert(sizeof(T) == m_mem->size()); | |||
|
|
|||
| if constexpr (sycl::usm::alloc::device == kind) | |||
| if constexpr (sycl::usm::alloc::device == Kind) | |||
There was a problem hiding this comment.
Where is this change coming from?
There was a problem hiding this comment.
There was a public member
static constexpr sycl::usm::alloc kind = Kind;
which seems to have vanished.
Normally I try and expose all the (non-parameter-pack) template parameters via typedefs and static constexpr constants, as it is much easier when users of the class need to query them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have been seeing SYCL compiler problems recently when using JIT mode. Compiling a debug version of the compiler revealed that these
staticvariables are problematic and I don't see much of a reason for keeping them necessarily.I still see
but that seems to be a different issue (possibly to be tackled later).