Add missing complex operations arithmetic types overloads #4034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
real, imag, and conj
masterleinad
approved these changes
May 18, 2021
core/src/Kokkos_Complex.hpp
Outdated
Comment on lines
721
to
724
| template <class T> | ||
| KOKKOS_INLINE_FUNCTION constexpr Impl::promote_t<T> imag(T) { | ||
| return T(); | ||
| } |
There was a problem hiding this comment.
I think it would be helpful to clarify that T cannot be arbitrary. Maybe something like
Suggested change
| template <class T> | |
| KOKKOS_INLINE_FUNCTION constexpr Impl::promote_t<T> imag(T) { | |
| return T(); | |
| } | |
| template <class FloatOrInteger> | |
| KOKKOS_INLINE_FUNCTION constexpr Impl::promote_t<FloatOrInteger> imag(FloatInteger) { | |
| return FloatOrInteger(); | |
| } |
similar to https://en.cppreference.com/w/cpp/numeric/complex/imag2.
There was a problem hiding this comment.
What about ArithmeticType?
There was a problem hiding this comment.
Sure, that sounds reasonable having https://en.cppreference.com/w/cpp/types/is_arithmetic in mind.
Rombur
approved these changes
May 19, 2021
brian-kelley
approved these changes
May 19, 2021
|
Retest this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #4033 (comment)
real, imag, and conj