Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing common mathematical function (absolute value) #4036

Merged
merged 3 commits into from
May 24, 2021

Conversation

dalg24
Copy link
Member

@dalg24 dalg24 commented May 19, 2021

Partially addressing #4033

core/src/Kokkos_MathematicalFunctions.hpp Outdated Show resolved Hide resolved
@dalg24 dalg24 requested a review from masterleinad May 21, 2021 14:49
@masterleinad
Copy link
Contributor

I have a slight preference towards something like

diff --git a/.github/workflows/continuous-integration-workflow.yml b/.github/workflows/continuous-integration-workflow.yml
index 892ca127a..c2ce93235 100644
--- a/.github/workflows/continuous-integration-workflow.yml
+++ b/.github/workflows/continuous-integration-workflow.yml
@@ -45,6 +45,13 @@ jobs:
       - name: maybe_disable_death_tests
         if: ${{ matrix.distro == 'fedora:rawhide' }}
         run: echo "GTEST_FILTER=-*DeathTest*" >> $GITHUB_ENV
+      - name: enable_precise_fp_mode
+        run: |
+          if ${{ matrix.cxx == 'icpx' }}; then
+            echo "EXTRA_CXX_FLAGS=-fp-model=precise" >> $GITHUB_ENV
+          else
+            echo "EXTRA_CXX_FLAGS=" >> $GITHUB_ENV
+          fi
       - name: build-and-test
         run: |
           ccache -z
@@ -56,6 +63,7 @@ jobs:
             -DKokkos_ENABLE_EXAMPLES=ON \
             -DKokkos_ENABLE_DEPRECATED_CODE_3=ON \
             -DCMAKE_CXX_COMPILER=${{ matrix.cxx }} \
+            -DCMAKE_CXX_FLAGS=${EXTRA_CXX_FLAGS} \
             -DCMAKE_BUILD_TYPE=${{ matrix.cmake_build_type }} \
             -DBUILD_NAME=${{ matrix.distro }}-${{ matrix.cxx }} \
             -DBUILD_JOBS=2 -DBINARY_DIR=builddir -DSITE=GitHub-Linux \

see https://github.com/masterleinad/kokkos/runs/2640376010?check_suite_focus=true saying "We only test in floating point safe mode. You are on your own if you use unsafe floating point operations (that happen to be enabled by default in certain Intel compilers)."
I can live with either, though.

@masterleinad
Copy link
Contributor

Retest this please.

1 similar comment
@masterleinad
Copy link
Contributor

Retest this please.

@crtrott crtrott merged commit 1aae70b into kokkos:develop May 24, 2021
@dalg24 dalg24 deleted the absolute_value branch May 24, 2021 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants