OpenMPTarget: Fix bug in for the case of a reducer. #4044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dalg24
previously approved these changes
May 24, 2021
| @@ -1641,7 +1641,8 @@ KOKKOS_INLINE_FUNCTION | |||
| for (iType i = loop_boundaries.start; i < loop_boundaries.end; i++) { | |||
| ValueType tmp = ValueType(); | |||
There was a problem hiding this comment.
This should likely also be replaced by reducer.init(...).
There was a problem hiding this comment.
Yes. Its a WIP. Sorry forgot to mark that label. Currently that loop is not encountered though.
dalg24
dismissed
their stale review
Non trivial changes have been pushed since approval
|
What is the status? |
This is ready for review. |
crtrott
approved these changes
Jun 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR replace
+withjoinin case when nested reduction is performed on a reducer.