Fixup global buffer overflow in hand rolled string manipulation #4070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dalg24
force-pushed
the
fixup_global_buffer_overflow
branch
from
e800b86
to
bcc0539
Compare
crtrott
approved these changes
Jun 4, 2021
nliber
previously requested changes
Jun 4, 2021
Co-Authored-By: Nevin Liber <nliber@anl.gov>
dalg24
force-pushed
the
fixup_global_buffer_overflow
branch
from
adaf20b
to
f2d1db5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced in #3824 (by me)