Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect macro definitions when compiling with Intel compiler on Windows #4087

Merged
merged 1 commit into from
Jun 22, 2021

Conversation

crtrott
Copy link
Member

@crtrott crtrott commented Jun 9, 2021

Define KOKKOS_RESTRICT as __restrict on Windows.
Disable KOKKOS_IMPL_ENABLE_STACKTRACE.
Define KOKKOS_THREAD_LOCAL as __declspec(thread).
Use __declspec for attribute.

Fixes #4080.

… Windows.

Define KOKKOS_RESTRICT as __restrict on Windows.
Disable KOKKOS_IMPL_ENABLE_STACKTRACE.
Define KOKKOS_THREAD_LOCAL as __declspec(thread).
Use __declspec for attribute.
@cjj19970505
Copy link

Thanks

Copy link
Contributor

@masterleinad masterleinad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@cjj19970505
Copy link

Please link this PR with #4080

Copy link
Member

@dalg24 dalg24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we get a review from another Windows aficionado?

(Approval from @crtrott is fine)

@crtrott crtrott merged commit 602b31c into kokkos:develop Jun 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants