Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compilation with latest MSVC version #4102

Merged
merged 1 commit into from
Jun 17, 2021
Merged

Fix compilation with latest MSVC version #4102

merged 1 commit into from
Jun 17, 2021

Conversation

crtrott
Copy link
Member

@crtrott crtrott commented Jun 17, 2021

No description provided.

DavidPoliakoff
DavidPoliakoff approved these changes Jun 17, 2021
View reviewed changes
Copy link
Contributor

@DavidPoliakoff DavidPoliakoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oof

masterleinad
masterleinad approved these changes Jun 17, 2021
View reviewed changes
Copy link
Contributor

@masterleinad masterleinad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

dalg24
dalg24 approved these changes Jun 17, 2021
View reviewed changes
Copy link
Member

@dalg24 dalg24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure we delete the branch after we merge

@crtrott
Copy link
Member Author

crtrott commented Jun 17, 2021

Yeah, VS studio issue that it pushed to origin instead of my fork, I will delete after it merged.

@crtrott crtrott merged commit 57111b1 into develop Jun 17, 2021
@crtrott crtrott deleted the fix-latest-msvc branch June 17, 2021 17:57
@masterleinad masterleinad mentioned this pull request Jun 17, 2021
Closed
@ndellingwood ndellingwood mentioned this pull request Jun 22, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dalg24 dalg24 dalg24 approved these changes

@masterleinad masterleinad masterleinad approved these changes

@DavidPoliakoff DavidPoliakoff DavidPoliakoff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@crtrott @dalg24 @masterleinad @DavidPoliakoff