Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use DPC++ broadcast extension in SYCL team_broadcast #4103

Merged
merged 1 commit into from
Jun 21, 2021
Merged

Use DPC++ broadcast extension in SYCL team_broadcast #4103

merged 1 commit into from
Jun 21, 2021

Conversation

masterleinad
Copy link
Contributor

DPC++ offers an extension that exactly does what we want, see https://github.com/intel/llvm/blob/sycl/sycl/doc/extensions/GroupAlgorithms/SYCL_INTEL_group_algorithms.asciidoc, avoiding some explicit barriers on our side.

@masterleinad masterleinad requested a review from nliber June 17, 2021 16:34
@masterleinad
Copy link
Contributor Author

The build failure for MSVC is unrelated, only SYCL source files are affected and the SYCL CI build passes.

nliber
nliber approved these changes Jun 19, 2021
View reviewed changes
Copy link
Contributor

@nliber nliber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@dalg24 dalg24 merged commit f85af9e into kokkos:develop Jun 21, 2021
@masterleinad masterleinad deleted the sycl_use_native_broadcast branch December 2, 2021 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dalg24 dalg24 dalg24 approved these changes

@nliber nliber nliber approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@masterleinad @dalg24 @nliber