-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove dependency between core and containers #4114
Remove dependency between core and containers #4114
Conversation
core/src/KokkosExp_InterOp.hpp
Outdated
// Duplicate from the header file for DynRankView to avoid core depending on | ||
// containers. | ||
template <class> | ||
struct is_dyn_rank_view : public std::false_type {}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suffix with _dupe
or similar to void possible confusion.
@ndellingwood Can you please confirm that this resolves #4109 for you? |
@masterleinad I'm beginning testing with the previous failing build config |
@masterleinad I'm still seeing compilation errors with a fresh build:
|
We need to conditionally enable the unit test |
@ndellingwood Would you give it another shot? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@masterleinad The recent update resolved the compilation errors, thanks!
Fixes #4109.