Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency between core and containers #4114

Merged
merged 3 commits into from
Jun 22, 2021

Conversation

masterleinad
Copy link
Contributor

Fixes #4109.

// Duplicate from the header file for DynRankView to avoid core depending on
// containers.
template <class>
struct is_dyn_rank_view : public std::false_type {};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suffix with _dupe or similar to void possible confusion.

@masterleinad
Copy link
Contributor Author

@ndellingwood Can you please confirm that this resolves #4109 for you?

@ndellingwood
Copy link
Contributor

@masterleinad I'm beginning testing with the previous failing build config

@ndellingwood
Copy link
Contributor

@masterleinad I'm still seeing compilation errors with a fresh build:

[ 16%] Building CXX object kokkos/core/unit_test/CMakeFiles/KokkosCore_TestCompileOnly.dir/TestInterOp.cpp.o
cd /ascldap/users/ndellin/Trilinos-dev/Build/NightlyFail/kokkos/core/unit_test && /ascldap/users/ndellin/kokkos/bin/nvcc_wrapper   -I/ascldap/users/ndellin/Trilinos-dev/Build/NightlyFail -I/ascldap/users/ndellin/Trilinos-dev/kokkos/tpls/gtest -I/ascldap/users/ndellin/Trilinos-dev/Build/NightlyFail/kokkos/core/src -I/ascldap/users/ndellin/Trilinos-dev/kokkos/core/src -I/ascldap/users/ndellin/Trilinos-dev/Build/NightlyFail/kokkos -I/ascldap/users/ndellin/Trilinos-dev/Build/NightlyFail/kokkos/core/unit_test -I/ascldap/users/ndellin/Trilinos-dev/kokkos/core/unit_test -I/ascldap/users/ndellin/Trilinos-dev/kokkos/core/unit_test/category_files  -pedantic -Wall -Wno-long-long -Wwrite-strings    -arch=sm_70  -Xcudafe --diag_suppress=esa_on_defaulted_function_ignored -O3 -DNDEBUG   -std=c++14 -o CMakeFiles/KokkosCore_TestCompileOnly.dir/TestInterOp.cpp.o -c /ascldap/users/ndellin/Trilinos-dev/kokkos/core/unit_test/TestInterOp.cpp
/ascldap/users/ndellin/Trilinos-dev/kokkos/core/unit_test/TestInterOp.cpp:46:10: fatal error: Kokkos_DynRankView.hpp: No such file or directory
 #include <Kokkos_DynRankView.hpp>
          ^~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make[2]: *** [kokkos/core/unit_test/CMakeFiles/KokkosCore_TestCompileOnly.dir/TestInterOp.cpp.o] Error 1

@dalg24
Copy link
Member

dalg24 commented Jun 22, 2021

We need to conditionally enable the unit test

@masterleinad
Copy link
Contributor Author

@ndellingwood Would you give it another shot?

Copy link
Contributor

@ndellingwood ndellingwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@masterleinad The recent update resolved the compilation errors, thanks!

@crtrott crtrott merged commit cfb94d9 into kokkos:develop Jun 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants