Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add XLClang as compiler #4120

Merged
merged 1 commit into from
Jun 29, 2021
Merged

Add XLClang as compiler #4120

merged 1 commit into from
Jun 29, 2021

Conversation

masterleinad
Copy link
Contributor

Fixes #4099.
@ndellingwood Can you please check that enabling OpenMP with XL works for you again with this patch?

I checked that -fopenpmp is also the flag that I get with #4105.

Note that https://cmake.org/cmake/help/latest/variable/CMAKE_LANG_COMPILER_ID.html lists both XL and XLClang but I see XLClang as compiler id for the compiler on Summit.

Conflicts:
	cmake/kokkos_functions.cmake
Copy link
Contributor

@ndellingwood ndellingwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This resolved the OpenMP compilation issues I had reported, thanks!

@ndellingwood
Copy link
Contributor

@crtrott this should be ready for merge

@crtrott crtrott merged commit a6198eb into kokkos:develop Jun 29, 2021
@masterleinad masterleinad deleted the add_xlclang branch July 6, 2021 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants