Unorderedmap clear() should zero the size() #4130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nliber
changed the title
|
Formatting issue. |
crtrott
approved these changes
Jun 30, 2021
Rombur
approved these changes
Jun 30, 2021
masterleinad
reviewed
Jul 6, 2021
masterleinad
approved these changes
Jul 7, 2021
masterleinad
approved these changes
Jul 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue #4128.
UnorderedMap::m_sizeis a cache of the size of the container (that is why is is markedmutable), which only gets updated whensize()is called on a modified (indicated by them_scalars(modified_idx)flag) map. This flag is only possibly set ininsertanderasemethods.clear()both clears outm_scalars(which effectively clears themodified_idxflag) and doesn't update them_sizevalue, hence the bug.I did verify that if we always recalculate the size, the correct value of
0is calculated.