Use sub_groups in SYCL parallel_scan #4147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masterleinad
moved this from In progress
to Awaiting Feedback
in Developer: Daniel Arndt
masterleinad
commented
Jul 8, 2021
| @@ -86,9 +86,9 @@ class ParallelScanSYCLBase { | |||
| void scan_internal(sycl::queue& q, const Functor& functor, | |||
| pointer_type global_mem, std::size_t size) const { | |||
| // FIXME_SYCL optimize | |||
| constexpr size_t wgroup_size = 32; | |||
| constexpr size_t wgroup_size = 128; | |||
There was a problem hiding this comment.
This change is not really necessary of course but is more in line with what we are doing for reductions at the moment.
nliber
approved these changes
Jul 12, 2021
Rombur
approved these changes
Jul 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One more step towards using subgroups where appropriate.
ValueOps::copy.