Remove KOKKOS_ENABLE_DEBUG_PRINT_KERNEL_NAMES #4150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Retest this please. |
dalg24
previously requested changes
Jul 12, 2021
Hmm... I want to at least discuss if we really want to drop this feature. People might be surprised that it just disappeared. Of course, deprecating is not really possible either. |
|
Meeting decision: Drop this entirely: SF F N A SA We drop this without warning and consider it a bug that it even existed (completely untested). Use kernel logger or so, |
masterleinad
force-pushed
the
cmake_kokkos_print_kernel_names
branch
from
3cfd866
to
b23baad
Compare
masterleinad
changed the title
|
I changed the pull request to remove KOKKOS_DEBUG_PRINT_KERNEL_NAMES instead. |
crtrott
reviewed
Jul 15, 2021
| Kokkos::fence(); | ||
| std::cout << "KOKKOS_DEBUG End parallel_for kernel: " << str << std::endl; | ||
| #endif | ||
| (void)str; |
There was a problem hiding this comment.
do we still need the (void)str?
There was a problem hiding this comment.
AFAICT, str is still used in all cases, so we don't have to do this (and none of the CI checks complains).
crtrott
approved these changes
Jul 15, 2021
DavidPoliakoff
approved these changes
Jul 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #3966 (comment). I think it's a good idea to have a useful preprocessor switch defined through CMake (and thus documented). Of course, the same effect can be achieved by using
Tools.If we say that that's the proper way and should always be preferred, I would rather remove the functionality in
Core.edit: We remove KOKKOS_ENABLE_DEBUG_PRINT_KERNEL_NAMES instead.