Fix mistaken logic in pthread creation #4157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@stanmoore1 may want to test this cherry-picked on the latest release for any performance implication. |
nliber
approved these changes
Jul 12, 2021
crtrott
reviewed
Jul 14, 2021
| if (0 == pthread_attr_init(&attr) || | ||
| 0 == pthread_attr_setscope(&attr, PTHREAD_SCOPE_SYSTEM) || | ||
| if (0 == pthread_attr_init(&attr) && | ||
| 0 == pthread_attr_setscope(&attr, PTHREAD_SCOPE_SYSTEM) && | ||
| 0 == pthread_attr_setdetachstate(&attr, PTHREAD_CREATE_DETACHED)) { |
There was a problem hiding this comment.
hm is this really &&? Not ||? Was it initially correct if any of these things are not set that it needs to recreated?
There was a problem hiding this comment.
Also, should pthread_attr_destroy only be called if the pthread_attr_init call succeeded? The POSIX spec says that "[t]he behavior is undefined if the value specified by the attr argument to pthread_attr_destroy() does not refer to an initialized thread attributes object."
|
That said maybe we don't want the conflict with the std::thread PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.