Fix a bug when using HIP atomic with Kokkos::Complex #4159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
__ballot returns an unsigned long long int in HIP and not an unsigned int like in CUDA
|
Retest this please |
crtrott
approved these changes
Jul 14, 2021
|
Regarding Desul, our version is way out of sync with the main desul repo right now since there are tons of fixes in our version which were only uncovered when integrating fully with Kokkos. I intend to do that backport to Desul when we got everything working, and then merge again into Kokkos with whatever changes code review there caused. |
|
Thanks for fixing this, all the KokkosKernels tests are now passing with real and complex 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
__ballot returns an
unsigned long long intin HIP and not anunsigned intlike in CUDA. With this PR, all the tests are enabled for HIP.