Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix thread-safety in HIP #4170

Merged
merged 2 commits into from
Jul 19, 2021
Merged

Fix thread-safety in HIP #4170

merged 2 commits into from
Jul 19, 2021

Conversation

Rombur
Copy link
Member

@Rombur Rombur commented Jul 19, 2021

Currently, HIP is only thread-safe for Team Policy. This fixes Range and MDRange.

@Rombur Rombur added this to Awaiting Feedback in Developer: Bruno Turcksin Jul 19, 2021
masterleinad
masterleinad approved these changes Jul 19, 2021
View reviewed changes
Copy link
Contributor

@masterleinad masterleinad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. We should have a test for all of this at some point, though. IIRC, you have that in preparation already?

@Rombur
Copy link
Member Author

Rombur commented Jul 19, 2021

I have a test but most backends do not it pass yet.

@crtrott
Copy link
Member

crtrott commented Jul 19, 2021

I am wondering about having an option which turns all the thread safety off for people like Stan, who need every micro second in dispatch they can get.

@crtrott crtrott merged commit 3a94ca6 into kokkos:develop Jul 19, 2021
@Rombur Rombur moved this from Awaiting Feedback to Done in Developer: Bruno Turcksin Aug 2, 2021
@Rombur Rombur deleted the hip_safety branch September 19, 2022 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@masterleinad masterleinad masterleinad approved these changes

@crtrott crtrott crtrott approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Developer: Bruno Turcksin
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Rombur @crtrott @masterleinad