Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for query_device example #4172

Merged
merged 2 commits into from
Jul 20, 2021
Merged

Fixes for query_device example #4172

merged 2 commits into from
Jul 20, 2021

Conversation

DavidPoliakoff
Copy link
Contributor

Solves #4167

Turns out we needed two things, actually.

  1. Change Kokkos::[subcomponent]::print_configuration to Kokkos::print_configuration
  2. The metadata only gets initialized when Kokkos::initialize is called, which this example didn't

masterleinad
masterleinad reviewed Jul 19, 2021
View reviewed changes
Copy link
Contributor

@masterleinad masterleinad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me except for the lone ";".

example/query_device/query_device.cpp Outdated Show resolved Hide resolved
@dalg24 @masterleinad
Fixup (stray semicolon)
487f559 
Co-authored-by: Daniel Arndt <arndtd@ornl.gov>
dalg24
dalg24 approved these changes Jul 20, 2021
View reviewed changes
Copy link
Member

@dalg24 dalg24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NOTE TO MERGER: squash the two commits

@crtrott crtrott merged commit a813aab into kokkos:develop Jul 20, 2021
@crtrott crtrott added this to In progress in Kokkos Release 3.5 via automation Jul 20, 2021
@crtrott crtrott moved this from In progress to Done in Kokkos Release 3.5 Jul 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dalg24 dalg24 dalg24 approved these changes

@masterleinad masterleinad masterleinad approved these changes

@crtrott crtrott crtrott approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Kokkos Release 3.5
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@DavidPoliakoff @dalg24 @masterleinad @crtrott