Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for Cray Clang to Makefile.kokkos #4176

Merged

Conversation

DavidPoliakoff
Copy link
Contributor

Cray Clang doesn't identify with a "CC-" string, it says "clang++" and more. Mainline clang says

s1042027:kokkos dzpolia$ clang++ -craype-verbose
clang-9: error: unknown argument: '-craype-verbose'
clang-9: error: no input files

Note the lack of "clang++." I'm using this to switch what Cray flag we use, to better match the CMakeLists method, we want -fopenmp as the flag for OpenMP for Cray Clang, not -fopenmp=libomp

@DavidPoliakoff DavidPoliakoff added this to In progress in Kokkos Release 3.5 via automation Jul 20, 2021
@DavidPoliakoff DavidPoliakoff added this to Awaiting Feedback in Developer: David P Jul 20, 2021
@DavidPoliakoff DavidPoliakoff moved this from In progress to Awaiting Feedback in Kokkos Release 3.5 Jul 20, 2021
Copy link
Contributor

@masterleinad masterleinad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me.

Copy link
Member

@Rombur Rombur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works but note that if you ask for the version, clang gives you something like clang version 10.0.0-4ubuntu1 while Cray clang gives you Cray clang version 12.0.2. It might be more robust in the long term to check the version. Since it's a Makefile, the current solution is good enough for me.

@dalg24
Copy link
Member

dalg24 commented Jul 23, 2021

This works but note that if you ask for the version, clang gives you something like clang version 10.0.0-4ubuntu1 while Cray clang gives you Cray clang version 12.0.2. It might be more robust in the long term to check the version. Since it's a Makefile, the current solution is good enough for me.

@DavidPoliakoff do you want me to merge as is or do you want to update according to Brunos suggestion?

@DavidPoliakoff
Copy link
Contributor Author

Hold off on merging this, I'll check it out on a machine. I'd like for the string we grep for to be Cray, I just need to verify

@masterleinad masterleinad moved this from Awaiting Feedback to In progress in Kokkos Release 3.5 Jul 27, 2021
@crtrott crtrott merged commit 63abdd1 into kokkos:develop Aug 2, 2021
Kokkos Release 3.5 automation moved this from In progress to Done Aug 2, 2021
@DavidPoliakoff DavidPoliakoff moved this from Awaiting Feedback to Done in Developer: David P Aug 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants