Fix two xl issues #4179
Merged
Fix two xl issues #4179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dalg24
reviewed
Jul 21, 2021
XL generates incorrect behavior see issue kokkos#4100
crtrott
force-pushed
the
fix-two-xl-issues
branch
from
1f80b19
to
c5bfa90
Compare
dalg24
approved these changes
Aug 2, 2021
|
Can the |
Either works. |
|
Retest this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds libatomic for XL which does require it for 64 bit compare exchange of complex and turns of the infinity test for long double where it generates wrong answers: see #4100