Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error message for NVHPC as host compiler #4227

Merged
merged 1 commit into from
Aug 12, 2021

Conversation

masterleinad
Copy link
Contributor

Fixes #4191 by improving the error message to require at least CMake 3.20.1.

@masterleinad masterleinad added this to In progress in Kokkos Release 3.5 via automation Aug 11, 2021
@crtrott crtrott moved this from In progress to Awaiting Feedback in Kokkos Release 3.5 Aug 11, 2021
Copy link
Contributor

@DavidPoliakoff DavidPoliakoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Always appreciate better error messages

@crtrott crtrott merged commit 3e978f3 into kokkos:develop Aug 12, 2021
Kokkos Release 3.5 automation moved this from Awaiting Feedback to Done Aug 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants