[HIP] Fix issue w/ static initialization of function attributes #4242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lized type and add test Change-Id: If09ba6647df0eda44bd00b55e29596179c9afe7b
masterleinad
approved these changes
Aug 16, 2021
dalg24
requested changes
Aug 16, 2021
|
By the way I'd swear we ran into that exact same kind of bug in the past |
Change-Id: Iebc5067270aa677fd70d67e80eafa1f8b3104258
dalg24
approved these changes
Aug 16, 2021
Rombur
approved these changes
Aug 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue w/ static initialization of function attributes on unspecialized type and add test.
This was a fun one to debug. Basically, on line 214 (https://github.com/kokkos/kokkos/compare/develop...arghdos:fix_launch_mechs?expand=1#diff-078df6e850082d467d9c91f0888ce3b7b5f5f0fcde51bc91a00845ec6dd9bfb0R214), we use a static initialization of the function attributes to "cache" them. However, this means that we will only get the function attributes for first kernel function pointer passed in. This means that on subsequent calls we will get (e.g.,) incorrect
localSizeBytes, which results in an incorrect launch bound determination at runtime.