Label all SYCL fences #4258
Label all SYCL fences #4258
Conversation
masterleinad
force-pushed
the
sycl_label_fences
branch
from
6233fc4
to
5a7263e
Compare
|
|
||
| return m_scratchFlags; | ||
| } | ||
|
|
||
| template <typename WAT> | ||
| void SYCLInternal::fence_helper(WAT& wat, const std::string& name, |
There was a problem hiding this comment.
I think @nliber meant it as an abbreviation for "wait and throw", implying that the template argument should be a type that implements wait_and_throw().
I was moving it here to escape circular header dependencies. We can discuss if not inlining this is problematic or not, of course.
| try { | ||
| (*queue)->wait_and_throw(); | ||
| } catch (sycl::exception const& e) { | ||
| Kokkos::Impl::throw_runtime_exception( | ||
| std::string("There was a synchronous SYCL error:\n") += | ||
| e.what()); | ||
| } |
There was a problem hiding this comment.
Why are you not using SYCLInternal::fence_helper here?
There was a problem hiding this comment.
#4258 (comment) says
[...] Also, the static fence can't really use the lowest level function anymore since we don't store the instance id with the queues. I decided to just copy the fence implementation for this case duplicating a few lines of code. Note that this case was treated in the Profiling interface separately already.
Previously, the final level calling
fencefunctions forSYCLdidn't have labels. This pull request shifts the respectiveProfilingcalls down.This requires that
USMObjectMemneeds another identifier for theinstance_idto report its fences. Also, the static fence can't really use the lowest level function anymore since we don't store the instance id with thequeues. I decided to just copy the fence implementation for this case duplicating a few lines of code. Note that this case was treated in theProfilinginterface separately already.I also noticed that we use
Kokkos::SYCLorKokkos::Experimental::SYCLrather inconsistently in strings so I went for the latter everywhere since the majority of cases already usedKokkos::Experimental::SYCL.