Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Zen2/3 also implying Zen Arch with Makefiles #4260

Merged
merged 1 commit into from
Aug 24, 2021

Conversation

crtrott
Copy link
Member

@crtrott crtrott commented Aug 24, 2021

Fixes #4248

@crtrott
Copy link
Member Author

crtrott commented Aug 24, 2021

make KOKKOS_DEVICES=Serial KOKKOS_ARCH=Zen2
g++ -I./ -I/ascldap/users/crtrott/Kokkos/kokkos/core/src -I/ascldap/users/crtrott/Kokkos/kokkos/containers/src -I/ascldap/users/crtrott/Kokkos/kokkos/algorithms/src -std=c++14 -march=znver2 -mtune=znver2 -I./ -I/ascldap/users/crtrott/Kokkos/kokkos/core/src -I/ascldap/users/crtrott/Kokkos/kokkos/containers/src -I/ascldap/users/crtrott/Kokkos/kokkos/algorithms/src -O3 -g -I/home/crtrott/Kokkos/KokkosBuild/Caraway/Serial/  -c main.cpp -o main.o
...


make KOKKOS_DEVICES=Serial KOKKOS_ARCH=Zen3
g++ -I./ -I/ascldap/users/crtrott/Kokkos/kokkos/core/src -I/ascldap/users/crtrott/Kokkos/kokkos/containers/src -I/ascldap/users/crtrott/Kokkos/kokkos/algorithms/src -std=c++14 -march=znver3 -mtune=znver3 -I./ -I/ascldap/users/crtrott/Kokkos/kokkos/core/src -I/ascldap/users/crtrott/Kokkos/kokkos/containers/src -I/ascldap/users/crtrott/Kokkos/kokkos/algorithms/src -O3 -g -I/home/crtrott/Kokkos/KokkosBuild/Caraway/Serial/  -c main.cpp -o main.o
...

make KOKKOS_DEVICES=Serial KOKKOS_ARCH=Zen
g++ -I./ -I/ascldap/users/crtrott/Kokkos/kokkos/core/src -I/ascldap/users/crtrott/Kokkos/kokkos/containers/src -I/ascldap/users/crtrott/Kokkos/kokkos/algorithms/src -std=c++14 -march=znver1 -mtune=znver1 -I./ -I/ascldap/users/crtrott/Kokkos/kokkos/core/src -I/ascldap/users/crtrott/Kokkos/kokkos/containers/src -I/ascldap/users/crtrott/Kokkos/kokkos/algorithms/src -O3 -g -I/home/crtrott/Kokkos/KokkosBuild/Caraway/Serial/  -c main.cpp -o main.o
...

@crtrott crtrott added this to In progress in Kokkos Release 3.5 via automation Aug 24, 2021
@crtrott crtrott moved this from In progress to Awaiting Feedback in Kokkos Release 3.5 Aug 24, 2021
Copy link
Contributor

@masterleinad masterleinad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@crtrott crtrott merged commit 3c7935a into kokkos:develop Aug 24, 2021
Kokkos Release 3.5 automation moved this from Awaiting Feedback to Done Aug 24, 2021
@crtrott crtrott deleted the fix-4248 branch August 24, 2021 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants