Introduce SYCLHostUSMSpace #4268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masterleinad
force-pushed
the
sycl_host_space
branch
from
527e771
to
4845630
Compare
masterleinad
force-pushed
the
sycl_host_space
branch
from
4845630
to
6fe6962
Compare
dalg24
reviewed
Aug 27, 2021
dalg24
reviewed
Aug 30, 2021
Comment on lines
+251
to
+257
| static_assert( | ||
| std::is_same< | ||
| Kokkos::Device<Kokkos::HostSpace::execution_space, | ||
| Kokkos::Experimental::SYCLSharedUSMSpace>, | ||
| Kokkos::Device<Kokkos::HostSpace::execution_space, | ||
| Kokkos::Experimental::SYCLSharedUSMSpace>>::value, | ||
| ""); |
There was a problem hiding this comment.
I see that this just copied from Cuda
kokkos/core/unit_test/cuda/TestCuda_Spaces.cpp
Lines 228 to 232 in 422c820
but can't help noting it is pointless.
dalg24
approved these changes
Aug 31, 2021
|
Retest this please. |
Rombur
reviewed
Sep 1, 2021
| @@ -146,6 +183,11 @@ static_assert(Kokkos::Impl::MemorySpaceAccess< | |||
| Kokkos::Experimental::SYCLSharedUSMSpace>::assignable, | |||
| ""); | |||
|
|
|||
| static_assert(Kokkos::Impl::MemorySpaceAccess< | |||
| Kokkos::Experimental::SYCLDeviceUSMSpace, | |||
| Kokkos::Experimental::SYCLDeviceUSMSpace>::assignable, | |||
There was a problem hiding this comment.
Shouldn't these be Kokkos::Experimental::SYCLHostUSMSpace?
crtrott
approved these changes
Sep 1, 2021
joeatodd
added a commit
to Ruyk/lammps
that referenced
this pull request
Dec 7, 2021
Depends on this PR from Kokkos: kokkos/kokkos#4268
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were discussing that there are situations where
SYCLHostUSMSpacewould have advantages overSYCLSharedUSMSpaceandSYCLDeviceUSMSpace(like launch latencies). To allow exploring this some more and to make the backend more similar to theCUDAone, this pull request introduces a new memory space.Additionally, this pull request copies the relevant backend-specific tests from the
CUDAtests.