Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding missing memory fence to serial exec space fence. #4292

Merged
merged 1 commit into from
Sep 4, 2021

Conversation

crtrott
Copy link
Member

@crtrott crtrott commented Sep 3, 2021

Without it relaxed mem ops in a kernel might not be visible
to the host process even after calling fence.

@crtrott crtrott added Blocks Promotion Overview issue for release-blocking bugs Bug Broken / incorrect code; it could be Kokkos' responsibility, or others’ (e.g., Trilinos) labels Sep 3, 2021
@crtrott
Copy link
Member Author

crtrott commented Sep 3, 2021

Fixes #4289

Without it relaxed mem ops in a kernel might not be visible
to the host process even after calling fence.
Copy link
Contributor

@masterleinad masterleinad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK.

@crtrott crtrott merged commit f575230 into kokkos:develop Sep 4, 2021
@crtrott crtrott deleted the add_mem_fence_to_serial branch September 4, 2021 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocks Promotion Overview issue for release-blocking bugs Bug Broken / incorrect code; it could be Kokkos' responsibility, or others’ (e.g., Trilinos)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants