adding KOKKOS_FORCEINLINE_FUNCTION to constbitset constructors #4296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
And to operator= |
crtrott
approved these changes
Sep 4, 2021
|
OK to test. |
dalg24
requested changes
Sep 7, 2021
|
@dalg24 I was looking to keep consistent between constbitset and bitset, and bitset had defined their copy constructors as inline, so I wanted to use define as inline, and figured to force the inline for optimization. But I have no strong opinion as long as device is in the macros somewhere ;) Would you rather me change it to use KOKKOS_FUNCTION or KOKKOS_INLINE_FUNCTION? I understand the argument that it might not be best to force inline and risk breaking someones code |
|
Please use |
dalg24
approved these changes
Sep 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding KOKKOS_FORCEDINLINE_FUNCTION to the ConstBitset constructors to allow for use on device and to match the bitset. Used in #4135