Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace remaining unnamed fences for SYCL #4304

Merged
merged 1 commit into from
Sep 8, 2021
Merged

Replace remaining unnamed fences for SYCL #4304

merged 1 commit into from
Sep 8, 2021

Conversation

masterleinad
Copy link
Contributor

I checked by commenting all versions that don't take a std::string in core/src.

@masterleinad masterleinad added this to Awaiting Feedback in Developer: Daniel Arndt Sep 8, 2021
DavidPoliakoff
DavidPoliakoff approved these changes Sep 8, 2021
View reviewed changes
Copy link
Contributor

@DavidPoliakoff DavidPoliakoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dalg24 dalg24 merged commit 2b8625e into kokkos:develop Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dalg24 dalg24 dalg24 approved these changes

@DavidPoliakoff DavidPoliakoff DavidPoliakoff approved these changes

@crtrott crtrott crtrott approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Developer: Daniel Arndt
Awaiting Feedback
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@masterleinad @dalg24 @DavidPoliakoff @crtrott